Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubevirt: Add Rancher projects rule #62

Merged
merged 1 commit into from
Dec 13, 2023
Merged

kubevirt: Add Rancher projects rule #62

merged 1 commit into from
Dec 13, 2023

Conversation

atanasdinov
Copy link
Contributor

@atanasdinov atanasdinov commented Dec 13, 2023 •
edited
Loading

  • Resolves an issue where KubeVirt deployment in Rancher would fail due to Rancher webhook preventing unauthorized PSA labels

@atanasdinov atanasdinov marked this pull request as ready for review December 13, 2023 12:01
@ipetrov117
Copy link
Contributor

As far as I understand, we are doing this in order to ensure that we conform with Rancher's webhook validation rules. So because we are trying to set the pod-security.kubernetes.io/enforce="privileged" label on the namespace we need to have a ClusterRole/ClusterRoleBindings that have the needed permissions (in this case updatepsa). Am I correct in assuming this?

@atanasdinov
Copy link
Contributor Author

Exactly.

@ipetrov117 ipetrov117 merged commit cd15973 into main Dec 13, 2023
1 check passed
@ipetrov117 ipetrov117 deleted the kubevirt-rancher branch December 13, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ipetrov117 ipetrov117 ipetrov117 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atanasdinov @ipetrov117