From ac6f370f6d50c119244279c669a0281392854dc0 Mon Sep 17 00:00:00 2001 From: Atanas Dinov Date: Tue, 24 Sep 2024 11:58:03 +0300 Subject: [PATCH] Use a non-concurrent approach to Kubernetes worker upgrades (#94) Signed-off-by: Atanas Dinov --- internal/upgrade/kubernetes.go | 2 +- internal/upgrade/kubernetes_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/upgrade/kubernetes.go b/internal/upgrade/kubernetes.go index 92fa88e..bde274d 100644 --- a/internal/upgrade/kubernetes.go +++ b/internal/upgrade/kubernetes.go @@ -85,7 +85,7 @@ func KubernetesWorkerPlan(nameSuffix, version string, drain bool, annotations ma workerPlan.Labels = map[string]string{ "k8s-upgrade": "worker", } - workerPlan.Spec.Concurrency = 2 + workerPlan.Spec.Concurrency = 1 workerPlan.Spec.NodeSelector = &metav1.LabelSelector{ MatchExpressions: []metav1.LabelSelectorRequirement{ { diff --git a/internal/upgrade/kubernetes_test.go b/internal/upgrade/kubernetes_test.go index 71436b7..56d3679 100644 --- a/internal/upgrade/kubernetes_test.go +++ b/internal/upgrade/kubernetes_test.go @@ -171,7 +171,7 @@ func TestKubernetesWorkerPlan_RKE2(t *testing.T) { assert.Empty(t, upgradeContainer.Args) assert.Equal(t, version, upgradePlan.Spec.Version) - assert.EqualValues(t, 2, upgradePlan.Spec.Concurrency) + assert.EqualValues(t, 1, upgradePlan.Spec.Concurrency) assert.True(t, upgradePlan.Spec.Cordon) assert.Equal(t, "system-upgrade-controller", upgradePlan.Spec.ServiceAccountName) @@ -219,7 +219,7 @@ func TestKubernetesWorkerPlan_K3s(t *testing.T) { assert.Empty(t, upgradeContainer.Args) assert.Equal(t, version, upgradePlan.Spec.Version) - assert.EqualValues(t, 2, upgradePlan.Spec.Concurrency) + assert.EqualValues(t, 1, upgradePlan.Spec.Concurrency) assert.True(t, upgradePlan.Spec.Cordon) assert.Equal(t, "system-upgrade-controller", upgradePlan.Spec.ServiceAccountName)