[fix]: try to reduce escapes to heap #1886
Conversation
|
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This PR focuses on internal optimizations to reduce memory escapes to the heap, improving code efficiency without affecting the external interface or behavior. Key Modifications:
Impact: These changes aim to improve memory usage and efficiency, making the code more performant without altering its external functionality. Observations: The PR appears to be a well-contained set of internal optimizations, which is a good practice for maintaining a healthy codebase. However, it would be beneficial to include more detailed comments or documentation explaining the reasoning behind these changes, especially for future maintainers who may not be familiar with the original motivation. |
| @@ -14,10 +14,10 @@ type UInt64Stat struct { | |||
| } | |||
|
|
|||
| func NewUInt64Stat(aggr, delta uint64) *UInt64Stat { | |||
| stat := &UInt64Stat{} | |||
| stat := UInt64Stat{} | |||
There was a problem hiding this comment.
fix Error: pkg/collector/stats/types/types.go:17:10: &UInt64Stat{} escapes to heap
ref https://github.com/sustainable-computing-io/kepler/actions/runs/12177539929/job/33966954289
and
https://github.com/sustainable-computing-io/kepler/actions/runs/12197388859/job/34026929446?pr=1886
| @@ -234,7 +234,7 @@ func getBoolConfig(configKey string, defaultBool bool) bool { | |||
| } | |||
|
|
|||
| func getIntConfig(configKey string, defaultInt int) int { | |||
| defaultValue := fmt.Sprintf("%d", defaultInt) | |||
| defaultValue := strconv.Itoa(defaultInt) | |||
There was a problem hiding this comment.
fix Error: pkg/config/config.go:237:36: defaultInt escapes to heap
ref https://github.com/sustainable-computing-io/kepler/actions/runs/12177539929/job/33966954289 and https://github.com/sustainable-computing-io/kepler/actions/runs/12197388859/job/34026929446?pr=1886
| @@ -57,18 +57,16 @@ var ( | |||
| LogisticTrainer, | |||
| ExponentialTrainer, | |||
| } | |||
| ModelOutputTypeConverter = []string{"AbsPower", "DynPower"} | |||
There was a problem hiding this comment.
Error: pkg/model/types/types.go:63:17: []string{...} escapes to heap
Error: pkg/model/types/types.go:69:1[7](https://github.com/sustainable-computing-io/kepler/actions/runs/12177539929/job/33966954289#step:4:8): []string{...} escapes to heap
fixed
Signed-off-by: Sam Yuan <[email protected]>
SamYuan1990
force-pushed
the
tryToreduceescapestoHeap
branch
from
a8104f8 to
d161bba
Compare
| @@ -50,6 +51,8 @@ func init() { | |||
| port = "10250" | |||
| } | |||
| podURL = "https://" + nodeName + ":" + port + "/pods" | |||
| http.DefaultTransport.(*http.Transport).TLSClientConfig = &tls.Config{InsecureSkipVerify: true} | |||
| client = http.Client{} | |||
There was a problem hiding this comment.
Error: pkg/kubelet/kubelet_pod_lister.go:69:12: &http.Client{} escapes to heap
make http client reuse
SamYuan1990
requested review from
sthaha,
dave-tucker,
maryamtahhan,
marceloamaral,
rootfs,
sunya-ch,
KaiyiLiu1234 and
vprashar2929
|
lgtm, @vimalk78 can you take a final check? thanks |
https://github.com/sustainable-computing-io/kepler/actions/runs/12177539929/job/33966954289
seems we have many nits can be improved to reduce our memory escapes to heap case.
in this PR, try to improve parts of them.