chore(compose): use fixed version of prometheus #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the issue where prometheus using `latest` is unable to scrape scaphandre metrics due to issue in scaphandre of having an invalid `Content-Type` header in Scaphandre's response. Signed-off-by: Vibhu Prashar <[email protected]>
|
🤖 SeineSailor Here is a concise summary of the pull request changes: Summary: This PR updates the Prometheus version in the Docker image from Key Modifications:
Impact: This change ensures a more predictable and consistent environment for scraping Scaphandre metrics, but does not affect the external interface or behavior of the code. Observations/Suggestions: None, as this is a straightforward version update with no observable impact on the codebase's external interface or behavior. |
|
Ref: |
sthaha
reviewed
Nov 15, 2024
| @@ -1,3 +1,3 @@ | |||
| FROM quay.io/prometheus/prometheus:latest | |||
| FROM quay.io/prometheus/prometheus:v2.55.0 | |||
There was a problem hiding this comment.
Could you please add a comment for pinning the version down?
sthaha
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue where prometheus using
latestis unable to scrape scaphandre metrics due to issue in scaphandre of having an invalidContent-Typeheader in Scaphandre's response.