Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compose): add fallback scrape protocol for Scaphandre service #1870

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

vprashar2929
Copy link
Collaborator

This update modifies the Prometheus scrape config for the Scaphandre service to use the fallback scrape protocol

  • Resolving an issue where Prometheus latest was unable to scrape Scaphandre service due to invalid Content-Type header in response
  • Switch Prometheus to use latest

This update modifies the Prometheus scrape config for the Scaphandre service
to use the fallback scrape protocol

* Resolving an issue where Prometheus `latest` was unable to scrape Scaphandre
  service due to invalid `Content-Type` header in response
* Switch Prometheus to use `latest`

Signed-off-by: vprashar2929 <[email protected]>
Copy link
Contributor

github-actions bot commented Dec 1, 2024

🤖 SeineSailor

Here is a concise summary of the pull request changes:

Summary: This pull request updates the Prometheus scrape configuration for the Scaphandre service by switching from a specific version (v2.55.0) to the latest version of Prometheus.

Key Modifications:

  • The Prometheus base image is updated to latest.
  • This change resolves an issue with the latest version unable to scrape the Scaphandre service due to an invalid Content-Type header in the response.

Impact: This change may affect the external interface or behavior of the code, as the latest version could have new features or modifications that may require adjustments in the monitoring and alerting rules.

Observations/Suggestions:

  • It would be beneficial to review the monitoring and alerting rules to ensure they are compatible with the latest version of Prometheus.
  • Consider adding tests to verify the Scaphandre service is properly scraped by the updated Prometheus version.
  • Document the changes and their potential impact on the codebase to ensure knowledge transfer and future maintenance.

@vimalk78 vimalk78 merged commit 33c5c73 into sustainable-computing-io:main Dec 9, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants