From 8b987dee789eeb6e7e87184e935425330e2501f5 Mon Sep 17 00:00:00 2001 From: Kobi Felton Date: Mon, 12 Jun 2023 20:50:21 +0100 Subject: [PATCH] Fix bug with categoricals in TSEMO (#250) --- summit/strategies/tsemo.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/summit/strategies/tsemo.py b/summit/strategies/tsemo.py index 83629ddd..1da74ad0 100644 --- a/summit/strategies/tsemo.py +++ b/summit/strategies/tsemo.py @@ -225,11 +225,11 @@ def suggest_experiments(self, num_experiments, prev_res: DataSet = None, **kwarg ) # NSGAII internal optimisation on spectrally sampled functions - self.logger.info("Optimizing models using NSGAII.") + self.logger.info("Optimizing acquisition function") # Categorical only domain if (self.domain.num_continuous_dimensions() == 0) and ( - self.domain.num_categorical_variables() == 1 + self.domain.num_categorical_variables() == len(self.domain.input_variables) ): X, yhat = self._categorical_enumerate(self.models) # Mixed domains @@ -238,6 +238,8 @@ def suggest_experiments(self, num_experiments, prev_res: DataSet = None, **kwarg # Continous domains elif self.categorical_combos is None and len(self.input_columns) > 0: X, yhat = self._nsga_optimize(self.models) + else: + raise ValueError("No valid domain found.") # Return if no suggestiosn found if X.shape[0] == 0 and yhat.shape[0] == 0: