Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check command #39

Closed
benmccann opened this issue Sep 27, 2024 · 5 comments · Fixed by #59
Closed

Add a check command #39

benmccann opened this issue Sep 27, 2024 · 5 comments · Fixed by #59

Comments

@benmccann
Copy link
Member

benmccann commented Sep 27, 2024

It could try to dynamically import svelte-check and invoke it programatically. It could be an optional peer dependency

@benmccann
Copy link
Member Author

We might need them to use the same CLI parsing library if we want to do that. svelte-check uses sade. So we'd either have to migrate to sade here or to commander in svelte-check. Or we migrate them both to parseArgs if we don't mind cutting a new major of svelte-check (sveltejs/language-tools#2521)

@benmccann
Copy link
Member Author

migrate in #41 works very well! I wonder if we should just copy that implementation for svelte-check as well?

@AdrianGonz97
Copy link
Member

hmm, im not so sure about using the same method for check as we did with migrate.

would always running the latest version of svelte-check be ideal? i can see a future where people are using sv check in CI and a new version of svelte-check rolls around that causes their CI to fail. that would certainly be awfully annoying

@benmccann
Copy link
Member Author

I believe if they have svelte-check installed then npx will use that version rather than the latest. But yeah, maybe it's better not to allow it to work without installing svelte-check and so I think I agree it should work differently than migrate

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Sep 29, 2024

But yeah, maybe it's better not to allow it to work without installing svelte-check and so I think I agree it should work differently than migrate

good idea! we can check if they have svelte-check installed locally and prompt them to install it as a package if they don't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants