chore: Deprecated rules that are irrelevant is Svelte 5 #899
Conversation
🦋 Changeset detectedLatest commit: edd4928 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
marekdedic
force-pushed
the
svelte-4-rule-deprecation
branch
from
f0f913c
to
05870f3
Compare
marekdedic
force-pushed
the
svelte-4-rule-deprecation
branch
from
05870f3
to
28f70c4
Compare
| @@ -10,6 +10,8 @@ since: 'v2.18.0' | |||
|
|
|||
| > require slot type declaration using the `$$Slots` interface | |||
|
|
|||
| - :warning: This rule was **deprecated**. Slots are deprecated in Svelte 5 | |||
There was a problem hiding this comment.
I don't think this should be deprecated. Because still Svelte5 can use slot. And still there are a lot of Svelte3/4 users.
My suggestion is that just remove this from recommended rules config.
(Same for other rules also.)
There was a problem hiding this comment.
Hmm, then we didn't understand each other in the original issue. Out of the discussed rules, only one was present in the recommended config - no-dynamic-slot-name. I proposed to mark as deprecated all rules that rely on features that are deprecated in Svelte itself. They would still be present for users of Svelte 4 and users relying on legacy svelte features. Only when Svelte itself removes the deprecated features do I think this plugin should remove the rules deprecated in this PR...
There was a problem hiding this comment.
Sorry for the late reply🙏
Indeed, that would be true if all Svelte users were using Svelte 5, but many are still on Svelte 3 or 4. Therefore, eslint-plugin-svelte should continue supporting Svelte 3/4 as well. we could deprecate or remove Svelte 3/4 rules in version 4 of eslint-plugin-svelte.
So, my opinion is not to deprecate these rules but to remove the Svelte 3/4-specific rules from the recommended config.
There was a problem hiding this comment.
After hearing your opinion, I think that's a good idea 👍
Additionally, it might be good to add documentation for those rules to say that they are no longer useful in Svelte v5.
There was a problem hiding this comment.
Ok, let's clarify this a bit -> #907
marekdedic
force-pushed
the
svelte-4-rule-deprecation
branch
from
28f70c4
to
edd4928
Compare
Closes #894