Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we should probably drop node 10 and add node 16 #129

Closed
oscard0m opened this issue Sep 7, 2021 · 5 comments · Fixed by #130
Closed

we should probably drop node 10 and add node 16 #129

oscard0m opened this issue Sep 7, 2021 · 5 comments · Fixed by #130

Comments

@oscard0m
Copy link
Contributor

oscard0m commented Sep 7, 2021

we should probably drop node 10 and add node 16

Originally posted by @benmccann in #120 (comment)
@oscard0m oscard0m mentioned this issue Sep 7, 2021
Merged
@Conduitry
Copy link
Member

Is there a reason to drop this (besides this version of Node being EOL)? This would be a breaking change, which I would like to avoid if possible.

@benmccann
Copy link
Member

I was only suggesting it because it's EOL, but no pressing reason to drop it

@oscard0m
Copy link
Contributor Author

oscard0m commented Sep 8, 2021

Should we keep version 10 but add version 16 to the matrix then? :)

@benmccann
Copy link
Member

Sounds reasonable to me

@oscard0m
Copy link
Contributor Author

oscard0m commented Sep 8, 2021 •
edited
Loading

Sounds reasonable to me

Done 💅🏽 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci(node-versions): add node16 in matrix
3 participants
@benmccann @oscard0m @Conduitry