Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression on VSCode Ext v109.2.3 #2589

Closed
huntabyte opened this issue Nov 16, 2024 · 4 comments
Closed

Regression on VSCode Ext v109.2.3 #2589

huntabyte opened this issue Nov 16, 2024 · 4 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@huntabyte
Copy link
Member

huntabyte commented Nov 16, 2024

Describe the bug

After updating to the latest Svelte for VSCode extension (v109.2.3), generic types are broken.

Here's a video of the issue I'm experiencing with the latest version. It goes away when I downgrade.

CleanShot.2024-11-15.at.21.42.01.mp4

More minimal reproduction than that linked below.

Reproduction

https://github.com/huntabyte/svelte-vscode-generics

Clone the repo, ensure you're running the latest version of the extension, check component.svelte.

Downgrade the extension and observe the errors go away.

Expected behaviour

Expect it to work the same as it does in v109.2.2

System Info

  • OS: Mac
  • IDE: VSCode

Which package is the issue about?

Svelte for VS Code extension

Additional Information, eg. Screenshots

No response

@huntabyte huntabyte added the bug Something isn't working label Nov 16, 2024
@dummdidumm
Copy link
Member

Likely because of #2571

@huntabyte
Copy link
Member Author

While we're on the topic of discussions, is it on the roadmap to eventually not have to explicitly declare the

type T = unknown
type U = unknown

In the module script tag for TS to properly recognize that these types do exist and that they're generic or is this a strict limitation of the language tools?

@dummdidumm
Copy link
Member

What do you mean by that? This shouldn't be necessary - infact, it's what's causing this bug to appear. If you remove it, your code will work fine (there's still a bug though we need to fix)

@huntabyte
Copy link
Member Author

Ah it's actually an eslint rule eslint(no-undef) that throws a fit about it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants