Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@link tags don't work in .svelte files #2604

Open
braebo opened this issue Nov 25, 2024 · 1 comment
Open

@link tags don't work in .svelte files #2604

braebo opened this issue Nov 25, 2024 · 1 comment
Labels
feature request New feature or request

Comments

@braebo
Copy link
Member

braebo commented Nov 25, 2024

Describe the bug

Doc comments with @link tags are no longer clickable links when rendered to their tooltip within a .svelte file.

Reproduction

The following interface:

interface FooBar {
  foo: 1
  bar: 2
  /**
   * Sum of {@link foo} and {@link bar}
   */
  foo_bar: 3
}

When placed (or imported) into a .svelte file, no longer shows clickable links.

Screenshot 2024-11-24 at 11 06 18 PM

Expected behaviour

In a .ts file, foo and bar are clickable links:

Screenshot 2024-11-24 at 11 06 54 PM

System Info

  • OS: MacOS
  • IDE: Cursor / VSCode

Which package is the issue about?

Svelte for VS Code extension

Additional Information, eg. Screenshots

No response

@braebo braebo added the bug Something isn't working label Nov 25, 2024
@jasonlyu123 jasonlyu123 added feature request New feature or request and removed bug Something isn't working labels Nov 25, 2024
@jasonlyu123
Copy link
Member

I am marking this as a "feature request" because this feature is done in the VSCode typescript extension instead of typescript's language service. This means this isn't a misconfiguration or a simple function call, we needed to rewrite the feature to fit into our codebase. If anyone is interested in implementing it, it's in https://github.com/microsoft/vscode/blob/d012408e88ffabd6456c367df4d343654da2eb10/extensions/typescript-language-features/src/languageFeatures/util/textRendering.ts#L180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants