Skip to content

fix: correctly transform reassignments to class fields in SSR mode #16051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2025

Conversation

Ocean-OS
Copy link
Contributor

@Ocean-OS Ocean-OS commented May 31, 2025

Fixes #16050. It appears that we weren't doing enough checks on reassignments in SSR mode, so reassignments like these...

this.foo.bar = 5;
foo.bar = 5;

would be incorrectly transformed to

this.bar(5);
this.bar(5);

If this.bar was a derived class field. Additionally, since derived class fields are now transformed to getters and setters per #15964, we don't need to transform (public) derived assignments to function calls.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 31, 2025

🦋 Changeset detected

Latest commit: 513e456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16051

@Ocean-OS Ocean-OS merged commit b5fcd11 into main Jun 1, 2025
14 checks passed
@Ocean-OS Ocean-OS deleted the gh-16050 branch June 1, 2025 07:53
This was referenced Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$derived causes SSR error when referencing a property with the same name as a nested reactive state
2 participants