fix:Added optional chaining to prevent console errors upon disconnecting element from the DOM #16956
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing element from the DOM
🦋 Changeset detectedLatest commit: af42af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dummdidumm
reviewed
Oct 15, 2025
| Promise.resolve().then(() => { | ||
| if (!this.$$cn && this.$$c) { | ||
| this.$$c.$destroy(); | ||
| this.$$c?.$destroy(); |
There was a problem hiding this comment.
I don't understand how this would fix it since we're checking if this.$$c is defined in the above if statement
There was a problem hiding this comment.
Oh my, I've bumped into it on some older version when the check was not there yet and didn't realise when creating this one... My bad! Sorry for that, closing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, when custom elements are disconnected from the DOM, errors appear in the console. This simple fix prevents that.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint