fix: disable css sourcemap in ssr (#201)

bluwy · web-flow · commit 031bbda88a05 · 2021-10-18T14:25:30.000+08:00
diff --git a/.changeset/plenty-wasps-explode.md b/.changeset/plenty-wasps-explode.md
@@ -0,0 +1,5 @@
+---
+'@sveltejs/vite-plugin-svelte': patch
+---
+
+Disable CSS sourcemap in SSR
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "rimraf": "^3.0.2",
     "semver": "^7.3.5",
     "sirv": "^1.0.18",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "ts-jest": "^27.0.7",
     "typescript": "^4.4.4",
     "vite": "^2.6.7"
diff --git a/packages/e2e-tests/autoprefixer-browerslist/package.json b/packages/e2e-tests/autoprefixer-browerslist/package.json
@@ -15,7 +15,7 @@
     "autoprefixer": "^10.3.7",
     "postcss": "^8.3.9",
     "postcss-load-config": "^3.1.0",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "svelte-preprocess": "^4.9.8",
     "vite": "^2.6.7"
   }
diff --git a/packages/e2e-tests/configfile-custom/package.json b/packages/e2e-tests/configfile-custom/package.json
@@ -12,7 +12,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/configfile-esm/package.json b/packages/e2e-tests/configfile-esm/package.json
@@ -12,7 +12,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "svelte-preprocess": "^4.9.8",
     "vite": "^2.6.7"
   },
diff --git a/packages/e2e-tests/custom-extensions/package.json b/packages/e2e-tests/custom-extensions/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/hmr/package.json b/packages/e2e-tests/hmr/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
     "node-fetch": "^2.6.5",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/kit-node/.env b/packages/e2e-tests/kit-node/.env
@@ -0,0 +1 @@
+VITE_FOO=FOOBARENV
diff --git a/packages/e2e-tests/kit-node/.gitignore b/packages/e2e-tests/kit-node/.gitignore
@@ -0,0 +1 @@
+!.env
diff --git a/packages/e2e-tests/kit-node/__tests__/kit.spec.ts b/packages/e2e-tests/kit-node/__tests__/kit.spec.ts
@@ -28,12 +28,16 @@ describe('kit-node', () => {
 			expect(await getText('h1')).toBe('Hello world!');
 			expect(await getText('#load')).toBe('SERVER_LOADED');
 			expect(await getText('#mount')).toBe('BEFORE_MOUNT');
+			expect(await getText('#i18n')).toBe('WELCOME');
+			expect(await getText('#env')).toBe('FOOBARENV');
 
 			// also get page as text to confirm
 			const html = await (await fetch(page.url())).text();
 			expect(html).toMatch('Hello world!');
 			expect(html).toMatch('SERVER_LOADED');
 			expect(html).toMatch('BEFORE_MOUNT');
+			expect(html).toMatch('WELCOME');
+			expect(html).toMatch('FOOBARENV');
 
 			// wait a bit for hydration to kick in
 			await sleep(550);
diff --git a/packages/e2e-tests/kit-node/package.json b/packages/e2e-tests/kit-node/package.json
@@ -11,7 +11,7 @@
     "@sveltejs/adapter-node": "^1.0.0-next.55",
     "@sveltejs/kit": "^1.0.0-next.184",
     "e2e-test-dep-svelte-api-only": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "svelte-i18n": "^3.3.13"
   },
   "type": "module",
diff --git a/packages/e2e-tests/kit-node/src/routes/index.svelte b/packages/e2e-tests/kit-node/src/routes/index.svelte
@@ -32,7 +32,7 @@
 		mount_status = 'AFTER_MOUNT';
 	});
 	setSomeContext();
-	addMessages('en', { welcome: 'hello' });
+	addMessages('en', { welcome: 'WELCOME' });
 	init({
 		fallbackLocale: 'en',
 		initialLocale: 'en'
@@ -50,7 +50,8 @@
 	<div id="after-child">after-child</div>
 	<div id="load">{load_status}</div>
 	<div id="mount">{mount_status}</div>
-	<div>{$_('welcome')}</div>
+	<div id="i18n">{$_('welcome')}</div>
+	<div id="env">{import.meta.env.VITE_FOO}</div>
 </main>
 
 <!-- HMR-TEMPLATE-INJECT -->
diff --git a/packages/e2e-tests/package-json-svelte-field/package.json b/packages/e2e-tests/package-json-svelte-field/package.json
@@ -13,7 +13,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/preprocess-with-vite/package.json b/packages/e2e-tests/preprocess-with-vite/package.json
@@ -11,7 +11,7 @@
     "@sveltejs/vite-plugin-svelte": "workspace:*",
     "sass": "^1.43.2",
     "stylus": "^0.55.0",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/svelte-preprocess/package.json b/packages/e2e-tests/svelte-preprocess/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "svelte-preprocess": "^4.9.8",
     "typescript": "^4.4.4",
     "vite": "^2.6.7"
diff --git a/packages/e2e-tests/vite-ssr-esm/package.json b/packages/e2e-tests/vite-ssr-esm/package.json
@@ -19,7 +19,7 @@
     "express": "^4.17.1",
     "npm-run-all": "^4.1.5",
     "serve-static": "^1.14.1",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/e2e-tests/vite-ssr/package.json b/packages/e2e-tests/vite-ssr/package.json
@@ -17,7 +17,7 @@
     "e2e-test-dep-esm-only": "workspace:*",
     "express": "^4.17.1",
     "serve-static": "^1.14.1",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/playground/big-component-library/package.json b/packages/playground/big-component-library/package.json
@@ -11,7 +11,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
     "carbon-components-svelte": "^0.45.1",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/playground/big/package.json b/packages/playground/big/package.json
@@ -9,7 +9,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7"
   }
 }
diff --git a/packages/playground/kit-demo-app/package.json b/packages/playground/kit-demo-app/package.json
@@ -10,7 +10,7 @@
   "devDependencies": {
     "@sveltejs/adapter-node": "^1.0.0-next.55",
     "@sveltejs/kit": "^1.0.0-next.184",
-    "svelte": "^3.43.2"
+    "svelte": "^3.44.0"
   },
   "type": "module",
   "dependencies": {
diff --git a/packages/playground/optimizedeps-include/package.json b/packages/playground/optimizedeps-include/package.json
@@ -10,7 +10,7 @@
   },
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "tinro": "^0.6.7",
     "vite": "^2.6.7"
   }
diff --git a/packages/playground/windicss/package.json b/packages/playground/windicss/package.json
@@ -13,7 +13,7 @@
   "devDependencies": {
     "@sveltejs/vite-plugin-svelte": "workspace:*",
     "diff-match-patch": "^1.0.5",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "vite": "^2.6.7",
     "vite-plugin-windicss": "^1.4.11"
   }
diff --git a/packages/vite-plugin-svelte/package.json b/packages/vite-plugin-svelte/package.json
@@ -68,7 +68,7 @@
     "diff-match-patch": "^1.0.5",
     "esbuild": "^0.13.8",
     "rollup": "^2.58.0",
-    "svelte": "^3.43.2",
+    "svelte": "^3.44.0",
     "tsup": "^5.4.0",
     "vite": "^2.6.7"
   }
diff --git a/packages/vite-plugin-svelte/src/utils/compile.ts b/packages/vite-plugin-svelte/src/utils/compile.ts
@@ -26,6 +26,13 @@ const _createCompileSvelte = (makeHot: Function) =>
 			log.debug(`setting cssHash ${hash} for ${normalizedFilename}`);
 			compileOptions.cssHash = () => hash;
 		}
+		if (ssr && compileOptions.enableSourcemap !== false) {
+			if (typeof compileOptions.enableSourcemap === 'object') {
+				compileOptions.enableSourcemap.css = false;
+			} else {
+				compileOptions.enableSourcemap = { js: true, css: false };
+			}
+		}
 
 		let preprocessed;
 
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@sveltejs/vite-plugin-svelte': patch
 +---
++
 +Disable CSS sourcemap in SSR
Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@`
`15`	`15`	`"autoprefixer": "^10.3.7",`
`16`	`16`	`"postcss": "^8.3.9",`
`17`	`17`	`"postcss-load-config": "^3.1.0",`
`18`		`- "svelte": "^3.43.2",`
	`18`	`+ "svelte": "^3.44.0",`
`19`	`19`	`"svelte-preprocess": "^4.9.8",`
`20`	`20`	`"vite": "^2.6.7"`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`	`},`
`13`	`13`	`"devDependencies": {`
`14`	`14`	`"@sveltejs/vite-plugin-svelte": "workspace:*",`
`15`		`- "svelte": "^3.43.2",`
	`15`	`+ "svelte": "^3.44.0",`
`16`	`16`	`"vite": "^2.6.7"`
`17`	`17`	`}`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@`
`9`	`9`	`},`
`10`	`10`	`"devDependencies": {`
`11`	`11`	`"@sveltejs/vite-plugin-svelte": "workspace:*",`
`12`		`- "svelte": "^3.43.2",`
	`12`	`+ "svelte": "^3.44.0",`
`13`	`13`	`"vite": "^2.6.7"`
`14`	`14`	`}`
`15`	`15`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`"devDependencies": {`
`14`	`14`	`"@sveltejs/vite-plugin-svelte": "workspace:*",`
`15`	`15`	`"node-fetch": "^2.6.5",`
`16`		`- "svelte": "^3.43.2",`
	`16`	`+ "svelte": "^3.44.0",`
`17`	`17`	`"vite": "^2.6.7"`
`18`	`18`	`}`
`19`	`19`	`}`