New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] dhcp: use composition in AsyncDHCP4Socket #1262

Draft

svinota wants to merge 1 commit into p10-dhcp-protocol from p10-dhcp-composition

Owner

svinota commented Jan 29, 2025

Don't inherit from AsyncRawSocket class, but instead use it as a property.

The idea is to ease AsyncRawSocket replacement with a mock class (the commit with such mock class will follow) to run unit testing.


          dhcp: use composition in AsyncDHCP4Socket

a82913e

svinota closed this

Owner Author

svinota commented Jan 30, 2025

@etene , I will rebase & rework it once we merge the main dhcp code.

svinota reopened this

etene force-pushed the p10-dhcp-protocol branch 3 times, most recently from 133c63f to 85a4bcc Compare

February 1, 2025 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet