Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fork or replacement of tachyons-sass #8314

Open
tim-lai opened this issue Dec 12, 2022 · 0 comments
Open

deps: fork or replacement of tachyons-sass #8314

tim-lai opened this issue Dec 12, 2022 · 0 comments
Labels
cat: style & presentation dependencies Pull requests that update a dependency file

Comments

@tim-lai
Copy link
Contributor

tim-lai commented Dec 12, 2022

Is your feature request related to a problem?

tachyons-sass appears to be a dead project, but remains as a production dependency of SwaggerUI. This has caused recent issues while attempting to resolve modern css builds.

Post PR merge feedback of this PR #8266 and its followup PR #8288

This PR introduces [email protected] as a production dependency which introduces 50 new dependencies into our production dependency tree. This dependencies will not be used in production bundles, but will pose additional false positive issues with SCA (Software Composition Analysis) tools or SBOM (Software Bill Of Materials) tools.

An unsuccessful effort was made to implement the suggestion using https://www.npmjs.com/package/string-replace-loader and/or https://www.npmjs.com/package/webpack-string-replacer. The issue is that these loaders appear incompatible with SwaggerUI's stylesheet webpack builder, which lacks direct import/require of /src code. In addition, they appear unable to search through nested sass imports.

We can fix the problem directly in our webpack config by utilizing simple text replacer plugin and replacing the *zoom with zoom.

Followup comment #8266 (comment) suggests that the *zoom line in question should be removed entirely.

Describe the solution you'd like

Ideally SwaggerUI should replace tachyons-sass entirely. However, it probably requires notable resource effort to build up a new set of Sass rules.

In the meantime, a SwaggerUI maintainer could fork and release a patch version of tachyons-sass with the desired removal of the IE7 hack, plus incorporate fixes to deprecation as noted below.

Describe alternatives you've considered

Additional context

tachyons-sass also includes a merged but unreleased fix that would solve webpack deprecation warnings, as noted in this swagger-ui issue: #7363

@tim-lai tim-lai added cat: style & presentation dependencies Pull requests that update a dependency file labels Dec 12, 2022
@tim-lai tim-lai changed the title deps: tachyons-sass fork or replacement deps: fork or replacement of tachyons-sass Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: style & presentation dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant