From bd8e5b42053caeb7e299c1c9bcfe254a6ff9eecd Mon Sep 17 00:00:00 2001 From: RodrigoSobral2000 Date: Thu, 10 Oct 2024 09:20:22 +0200 Subject: [PATCH] swancustomenvironments: Code simplification Specify builder_version only when it is provided --- .../swancustomenvironments/serverextension.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/SwanCustomEnvironments/swancustomenvironments/serverextension.py b/SwanCustomEnvironments/swancustomenvironments/serverextension.py index 274ac6ef..716a2f9c 100644 --- a/SwanCustomEnvironments/swancustomenvironments/serverextension.py +++ b/SwanCustomEnvironments/swancustomenvironments/serverextension.py @@ -29,7 +29,10 @@ def get(self): builder = self.get_query_argument("builder", default="") builder_version = self.get_query_argument("builder_version", default="") - arguments = ["--repo", repository, "--repo_type", repo_type, "--builder", builder, "--builder_version", builder_version] + arguments = ["--repo", repository, "--repo_type", repo_type, "--builder", builder] + if builder_version: + arguments.extend(("--builder_version", builder_version)) + makenv_process = subprocess.Popen([self.makenv_path, *arguments], stdout=subprocess.PIPE, stderr=subprocess.STDOUT) for line in iter(makenv_process.stdout.readline, b""):