Add encoding-impl test

Author: quininer

Cargo.lock

@@ -18,6 +18,32 @@ use crate::Atom;
 #[repr(transparent)]
 pub struct Wtf8Atom(pub(super) hstr::Wtf8Atom);
 
+#[cfg(feature = "encoding-impl")]
+impl cbor4ii::core::enc::Encode for Wtf8Atom {
+    #[inline]
+    fn encode<W: cbor4ii::core::enc::Write>(
+        &self,
+        writer: &mut W,
+    ) -> Result<(), cbor4ii::core::enc::Error<W::Error>> {
+        cbor4ii::core::types::Bytes(self.as_bytes()).encode(writer)
+    }
+}
+
+#[cfg(feature = "encoding-impl")]
+impl<'de> cbor4ii::core::dec::Decode<'de> for Wtf8Atom {
+    #[inline]
+    fn decode<R: cbor4ii::core::dec::Read<'de>>(
+        reader: &mut R,
+    ) -> Result<Self, cbor4ii::core::dec::Error<R::Error>> {
+        let s = <cbor4ii::core::types::Bytes<&[u8]>>::decode(reader)?;
+
+        // This is not sound, maybe Wtf8Buf should make bytes operations safe
+        Ok(Self(hstr::Wtf8Atom::from(unsafe {
+            Wtf8Buf::from_bytes_unchecked(s.0.into())
+        })))        
+    }
+}
+
 #[cfg(feature = "arbitrary")]
 #[cfg_attr(docsrs, doc(cfg(feature = "arbitrary")))]
 impl<'a> arbitrary::Arbitrary<'a> for Wtf8Atom {

crates/swc_atoms/src/wtf8_atom.rs

@@ -55,10 +55,12 @@ walkdir           = { workspace = true }
 codspeed-criterion-compat = { workspace = true }
 swc_ecma_ast = { version = "17.0.0", path = "../swc_ecma_ast", features = [
   "serde-impl",
+  "encoding-impl",
 ] }
 swc_ecma_visit = { version = "17.0.0", path = "../swc_ecma_visit" }
 swc_malloc = { version = "1.2.4", path = "../swc_malloc" }
 testing = { version = "17.0.0", path = "../testing" }
+cbor4ii = { workspace = true, features = [ "use_std" ] }
 
 [[example]]
 name = "typescript"

crates/swc_ecma_parser/Cargo.toml

@@ -63,11 +63,28 @@ fn run_spec(file: &Path, output_json: &Path, config_path: &Path) {
             is_test262: false,
         });
 
-        let json =
-            serde_json::to_string_pretty(&program).expect("failed to serialize module as json");
+        // json
+        {
+            let json =
+                serde_json::to_string_pretty(&program).expect("failed to serialize module as json");
+
+            if StdErr::from(json).compare_to_file(output_json).is_err() {
+                panic!()
+            }
+        }
+
+        // cbor
+        {
+            use cbor4ii::core::utils::{ BufWriter, SliceReader };
+            use cbor4ii::core::enc::Encode;
+            use cbor4ii::core::dec::Decode;
+
+            let mut buf = BufWriter::new(Vec::new());
+            program.encode(&mut buf).unwrap();
 
-        if StdErr::from(json).compare_to_file(output_json).is_err() {
-            panic!()
+            let buf = buf.into_inner();
+            let mut buf = SliceReader::new(buf.as_slice());
+            let _program = Program::decode(&mut buf).unwrap();
         }
 
         Ok(())