Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(swc_core): Fix typo in swc_core feature #9979

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

mischnic
Copy link
Contributor

  • Fix typo in the ecma_ast_serde feature
  • Add a ecma_visit_serde feature

@mischnic mischnic requested a review from a team as a code owner January 31, 2025 13:44
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: e0ee69b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mischnic mischnic force-pushed the visit-serde-feature branch from 0ec1d9f to 48b2ba8 Compare January 31, 2025 14:08
@kdy1 kdy1 self-assigned this Jan 31, 2025
@kdy1 kdy1 added this to the Planned milestone Jan 31, 2025
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kdy1 kdy1 changed the title fix: Fix typo in swc_core feature fix(swc_core): Fix typo in swc_core feature Jan 31, 2025
@kdy1 kdy1 enabled auto-merge (squash) January 31, 2025 14:10
@kdy1 kdy1 merged commit 99a6339 into swc-project:main Jan 31, 2025
171 checks passed
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #9979 will degrade performances by 4.25%

Comparing mischnic:visit-serde-feature (e0ee69b) with main (eebb0ea)

Summary

⚡ 3 improvements
❌ 2 regressions
✅ 191 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
es/full/minify/libraries/jquery 204.1 ms 197.7 ms +3.21%
es/full/minify/libraries/lodash 233 ms 243.3 ms -4.25%
es/lints/libs/react 1.8 ms 1.7 ms +6.23%
es/minifier/libs/jquery 165 ms 156.1 ms +5.71%
es/minifier/libs/vue 227.6 ms 236.1 ms -3.59%

@mischnic mischnic deleted the visit-serde-feature branch February 3, 2025 10:02
@kdy1 kdy1 modified the milestones: Planned, v1.10.13, v1.10.14 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants