Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in setup instructions as a submodule #936

Closed
bkmgit opened this issue Jul 23, 2023 · 3 comments
Closed

Pull in setup instructions as a submodule #936

bkmgit opened this issue Jul 23, 2023 · 3 comments
Labels
status:out of scope Proposed changes are out of scope

Comments

@bkmgit
Copy link

bkmgit commented Jul 23, 2023

The setup instructions are also used in the Shell novice lesson. Referring to the workshop template is a little confusing. Would you consider using a git submodule to allow them to be within the main lesson?

@zkamvar
Copy link
Contributor

zkamvar commented Jul 24, 2023

IMO, this is not a good solution because working with submodules is difficult even for people who are comfortable with Git. The problem arises because submodules by default will point to a single commit in the repository, but in a case like this, the lesson maintainers would much prefer to have them point to the HEAD of the repository, which is not straightforward (source: I've had to do this very thing for the lesson transition and it can be frustrating).

@zkamvar
Copy link
Contributor

zkamvar commented Jul 24, 2023

There has been discussion in the past about this, but not much capacity to address it, I'm afraid: carpentries/maintainer-RFCs#9

@kekoziar
Copy link
Contributor

I'm closing this issue as it's out of scope for the lesson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:out of scope Proposed changes are out of scope
Projects
None yet
Development

No branches or pull requests

3 participants