Multipart Support

[jjl]

Hi. Thanks for writing Ivar, it's helping us manage a smooth migration away from a legacy codebase.

One feature we're missing is multipart body support. It looks like Ivar doesn't have this yet. I'd be willing to contribute it if you don't have plans, but we'd need to discuss a dependency on something else for it.

[swelham]

Hi, I'm pleased to hear this lib is helping out 😃

Technically Ivar does multipart already as it supports file uploads and the only adapter currently implemented also supports it. All Ivar does is create a common format that gets passed into the adapter, which then converts it into the format that is required by the underlying lib (HTTPoison for example).

I think what we need here is to extend the put_body functions by adding code that will accept some easy to craft input and then update the adapter code to take this into account.

Could you provide examples of how you would like to see Ivar work with a multipart body? Or if you fancy having a go at implementing it, please feel free to put in a PR and we can discuss it further there.

[jjl]

Aha, I only looked at put_body and didn't see it.

Perhaps something like clj-http's multipart option? here (grep for 'multipart')

I'll have a look tomorrow at work about doing it myself.

[swelham]

Ok, sounds good.

Feel free to ask any questions or discuss ideas, I'm happy to help.

[jjl]

How about I make it so your example works with a :multipart type?

[swelham]

Yes I believe that would be a good approach.

One consideration is whether to store the multipart data in a separate list to the files list and let the adapter merge them together, or whether we should merge them together before they reach the adapter.

[jjl]

At the moment, I'm going for the principle of smallest change, so i'm trying to avoid changing the format spoken between ivar and the adapter by simply doing what HTTPoison does.

[swelham]

Ok sounds good 👍