Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stringified interface #2

Open
swfsql opened this issue Jul 29, 2020 · 1 comment
Open

Stringified interface #2

swfsql opened this issue Jul 29, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@swfsql
Copy link
Owner

swfsql commented Jul 29, 2020

The interface is currently using stringified objects instead of the objects themselves.
I think that this is less efficient, since this includes some serialization/deserialization steps.
Besides that, the generated documents are more clear if the interfaces use structural types, instead of using String.

I'd prefer if callback functions parameters were not stringfied function names, but also references to the javascript functions themselves, as it would enable some improvements on the callback data flow.

@swfsql swfsql added the enhancement New feature or request label Jul 29, 2020
@swfsql
Copy link
Owner Author

swfsql commented Aug 9, 2020

Currently, as the interface is largely stringified, direct JsValue (with wasm_bindgen) translation of structs are being replaced by derivations from serde, as they are more malleable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant