Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift's Windows installer is missing the features.json file for docc and clang #74634

Closed
jakepetroules opened this issue Jun 21, 2024 · 1 comment · Fixed by swiftlang/swift-installer-scripts#307
Closed

Swift's Windows installer is missing the features.json file for docc and clang #74634

jakepetroules opened this issue Jun 21, 2024 · 1 comment · Fixed by swiftlang/swift-installer-scripts#307
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. Windows Platform: Windows

Comments

@jakepetroules
Copy link
Contributor

Description

I'd expect "features.json" to be present in the following directories:

%LOCALAPPDATA%\Programs\Swift\Toolchains\6.0.0+Asserts\usr\share\clang
%LOCALAPPDATA%\Programs\Swift\Toolchains\6.0.0+Asserts\usr\share\docc

Currently, it is only present in

%LOCALAPPDATA%\Programs\Swift\Toolchains\6.0.0+Asserts\usr\share\swift

Reproduction

N/A

Expected behavior

N/A

Environment

Swift version 6.0-dev (LLVM e878388283d7b73, Swift eb92e6e)
Target: x86_64-unknown-windows-msvc

Additional information

No response
@jakepetroules jakepetroules added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. Windows Platform: Windows triage needed This issue needs more specific labels labels Jun 21, 2024
@compnerd
Copy link
Member

DocC is not yet available due to this outstanding change: swiftlang/swift-docc#668

Adding in features.json should just be a matter of updating the manifest in https://github.com/apple/swift-installer-scripts

@compnerd compnerd removed the triage needed This issue needs more specific labels label Jun 21, 2024
compnerd added a commit to compnerd/swift-installer-scripts that referenced this issue Jun 22, 2024
@compnerd
WiX: package features.json for clang
e0dc634 
Include `features.json` from clang to allow tooling to detect features supported by the C/C++ compiler.

Fixes: swiftlang/swift#74634
@compnerd compnerd mentioned this issue Jun 22, 2024
Merged
compnerd added a commit to compnerd/swift-installer-scripts that referenced this issue Sep 13, 2024
@compnerd
WiX: package features.json for clang
c55ebbd 
Include `features.json` from clang to allow tooling to detect features supported by the C/C++ compiler.

Fixes: swiftlang/swift#74634
@compnerd compnerd mentioned this issue Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. Windows Platform: Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WiX: package features.json for clang compnerd/swift-installer-scripts
2 participants
@compnerd @jakepetroules