[cxx-interop] Fix crash when using bridging headers in reverse interop #83540
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code had the assumption that clang nodes always have owning modules. In fact, when a header is imported via `-import-objc-header` this is not true. rdar://157489426
Xazax-hun
requested review from
zoecarver,
egorzhdan,
j-hui and
fahadnayyar
as code owners
Xazax-hun
requested review from
susmonteiro,
hnrklssn,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Windows |
Xazax-hun
added a commit
to Xazax-hun/swift
that referenced
this pull request
Aug 7, 2025
…nterop Explanation: The original code had the assumption we only import modules. However, there is a flag to import an umbrella header in which case the clang nodes have no owning module. This PR prevents a null dereference in that case. Issues: rdar://157489426 Original PRs: swiftlang#83540 Risk: Low, added a check to avoid null dereference. Testing: Added a compiler test. Reviewers: @egorzhdan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code had the assumption that clang nodes always have owning modules. In fact, when a header is imported via
-import-objc-headerthis is not true.rdar://157489426