Skip to content

Commit 0329f7c

Browse files
authored
Merge pull request #20 from tegonal/dev/metabase-version
use hard-coded metabase dependency instead of relative project folder
2 parents ec76619 + a0041e1 commit 0329f7c

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

deps.edn

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,21 +5,24 @@
55
"resources"
66
]
77

8+
:deps {
9+
org.clojure/clojure {:mvn/version "1.11.1"}
10+
; replace also the version in metabase-plugin.yaml
11+
metabase/metabase-core {:git/url "https://github.com/metabase/metabase.git" :git/tag "v0.43.0-rc2" :git/sha "4bac723514"}
12+
metabase/build-drivers {:git/url "https://github.com/metabase/metabase.git" :git/tag "v0.43.0-rc2" :git/sha "4bac723514" :deps/root "bin/build-drivers"}
13+
}
14+
815
; build the driver with `clojure -X:build` assumes that:
9-
; 1. the metabase repo (https://github.com/metabase/metabase) exists in ../metabase
10-
; 2. the correct tag is checked out `git checkout v...`
11-
; 3. `clojure -X:deps prep` was run in ../metabase as well as in ../metabase/modules/drivers
12-
; 4. You have turned the relative :paths above into absolute paths
16+
; 1. You have turned the relative :paths above into absolute paths
1317
:aliases {
14-
:build {
15-
;; as soon as extra-deps supports prep-lib we can use {:git/url "https://github.com/metabase/metabase.git" :git/tag "v0.41.7" :git/sha "5d45269b16"}
16-
:extra-deps {metabase/metabase-core {:local/root "../metabase"}
17-
metabase/build-drivers {:local/root "../metabase/bin/build-drivers"}}
18+
:build {
1819
:exec-fn build-drivers.build-driver/build-driver!
1920
:exec-args {:driver :teradata
2021
:project-dir "."
2122
:target-dir "./target"}
2223

2324
}
25+
; We don't want to include metabase nor clojure in the uber jar
26+
:oss {:replace-deps {} }
2427
}
2528
}

resources/metabase-plugin.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
info:
22
name: Metabase Teradata Driver
3+
# also replace the version in deps.edn if you change the metabase version here
34
version: 1.0.2-metabase-v0.43.0-rc2-teradata-jdbc-17.10
45
description: Allows Metabase to connect to Teradata databases. Community Supported driver.
56
dependencies:

0 commit comments

Comments
 (0)