Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Correct a typo in post-accordion-item component #4381

Closed
alionazherdetska opened this issue Jan 6, 2025 · 1 comment · Fixed by #4391
Closed

[bug]: Correct a typo in post-accordion-item component #4381

alionazherdetska opened this issue Jan 6, 2025 · 1 comment · Fixed by #4391
Assignees
@schaertim
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@alionazherdetska
Copy link
Contributor

There is a typo in the post-accordion-item component code. Specifically, the closest method is attempting to find a post-accorddion element (misspelling of "accordion").

Image
@alionazherdetska alionazherdetska added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package labels Jan 6, 2025
@alionazherdetska alionazherdetska added this to the PPNL Support milestone Jan 6, 2025
@alionazherdetska alionazherdetska changed the title [bug]: [bug]: Correct a typo in post-accordion Jan 6, 2025
@alionazherdetska alionazherdetska changed the title [bug]: Correct a typo in post-accordion [bug]: Correct a typo in post-accordion-item component Jan 6, 2025
@gfellerph
Copy link
Member

@alionazherdetska you can directly submit a PR if you find small stuff like that. This is way faster than to create a ticket first.

@schaertim schaertim self-assigned this Jan 7, 2025
@schaertim schaertim moved this from 👀 Triage to 🕹️ Coding in progress in Design System Production Board Jan 7, 2025
@schaertim schaertim linked a pull request Jan 7, 2025 that will close this issue
chore(components): fixed typo in post-accordion-item #4391
Merged
@schaertim schaertim moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Jan 7, 2025
@schaertim schaertim moved this from 🤬 Dev in Code Review to 🕹️ Coding in progress in Design System Production Board Jan 14, 2025
@schaertim schaertim moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Jan 14, 2025
@github-project-automation github-project-automation bot moved this from 🤬 Dev in Code Review to 🚀 Done in Design System Production Board Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schaertim schaertim

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

chore(components): fixed typo in post-accordion-item swisspost/design-system
3 participants
@gfellerph @schaertim @alionazherdetska