Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header: Improve active route prop comparison #2751

Open
gfellerph opened this issue Mar 4, 2024 · 0 comments · May be fixed by #4396
Open

Header: Improve active route prop comparison #2751

gfellerph opened this issue Mar 4, 2024 · 0 comments · May be fixed by #4396
Assignees
Labels
enhancement New feature or request 🧷 has workaround 📦 internet-header Related to the @swisspost/internet-header package request

Comments

@gfellerph
Copy link
Member

When declaring the active-route prop on the internet header, it's necessary to specify the full URL for an exact match.

If the following link should be higlighted in the nav, <a href="https://service.post.ch/test/example">Test example</a> it should be possible to do that by setting <swisspost-internet-header active-route="/test/example"></swisspost-internet-header> instead of the full URL.

@gfellerph gfellerph added enhancement New feature or request 📦 internet-header Related to the @swisspost/internet-header package labels Mar 4, 2024
@github-actions github-actions bot added the stale label Jun 18, 2024
@gfellerph gfellerph removed the stale label Aug 21, 2024
@gfellerph gfellerph moved this from 🗃️ Ready for work to 👀 Triage in Design System Production Board Aug 21, 2024
@gfellerph gfellerph moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Sep 6, 2024
@gfellerph gfellerph added this to the Long Term Support milestone Nov 28, 2024
@schaertim schaertim self-assigned this Jan 7, 2025
@schaertim schaertim moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Jan 7, 2025
@schaertim schaertim moved this from 🕹️ Coding in progress to 🤬 Dev in Code Review in Design System Production Board Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🧷 has workaround 📦 internet-header Related to the @swisspost/internet-header package request
Projects
Status: 🤬 Dev in Code Review
2 participants