-
Notifications
You must be signed in to change notification settings - Fork 21
feat(components): update post-popovercontainer animation and fix menu trigger and focus delays #6579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
myrta2302
wants to merge
33
commits into
main
Choose a base branch
from
6538-bug-fix-post-menu-animation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3feb44f The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
oliverschuerch
requested changes
Nov 5, 2025
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



📄 Description
This PR follows #6606:
post-popovercontainerto open with animation only when animation is set to 'pop-in'.post-menuto handle focus and aria-expanded on the trigger inpostBeforeToggleinstead ofpostToggled, fixing related delays.animationprop to thepost-menuto set the animation.menuAnimationto thepost-breadcrumbsandpost-language-switchcomponents to allow users to set the animation or use' none' to disable it.🔮 Design review
📝 Checklist