Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the way we're handling telegram responses #34

Open
elboletaire opened this issue Feb 4, 2019 · 1 comment
Open

Review the way we're handling telegram responses #34

elboletaire opened this issue Feb 4, 2019 · 1 comment
Labels
bug Something isn't working

Comments

@elboletaire
Copy link
Member

Seems that, when a telegram message fails, the entire operator crashes and the entire payload of that task is moved to the dead-letter in consequence.

We should check the way telegram messages are handled, specially, when they fail.
@elboletaire elboletaire added the bug Something isn't working label Feb 4, 2019
@elboletaire elboletaire changed the title Review the way we're managing telegram responses Review the way we're handling telegram responses Feb 4, 2019
@elboletaire elboletaire mentioned this issue Feb 4, 2019
Closed
@elboletaire
Copy link
Member Author

A workaround for this could be to set allowFailure to true by default in the telegram plugin. Although I don't like too much this solution.... I think we need to rethink how the promise chain responses are returned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@elboletaire