This repository has been archived by the owner on Sep 28, 2022. It is now read-only.

Prepared Statement Bug #16

Open

razzbee opened this issue Mar 21, 2020 · 5 comments

razzbee commented Mar 21, 2020 •

edited

Loading

Hello, errors in a prepared statement doesn't get reported, example:

$stmt = $db->prepare("my_query, "SELECT * from non_existing_table");

Here, non_existing_table doesnt exists, but $stmt returns true
and also :

$db->error is null

The text was updated successfully, but these errors were encountered:

Collaborator

codercms commented Apr 5, 2020

@sy-records I can confirm this is a bug, prepare is always returning true even if it fails.
https://github.com/swoole/ext-postgresql/blob/v4.4.x/swoole_postgresql_coro.cc#L620

Collaborator

codercms commented Apr 5, 2020

I fixed it in this PR - #19 (https://github.com/swoole/ext-postgresql/pull/19/files#diff-f6c52869d82feeba7cef8b1ab64732daR652)

Member

sy-records commented Apr 5, 2020

Thanks for your contribution, please wait for review. @codercms

Collaborator

codercms commented Apr 9, 2020 •

edited

Loading

@razzbee #19 is merged into v4.4.x branch. Can you confirm that your issue is resolved?

Author

razzbee commented Apr 17, 2020

I will provide a feedback after testing, Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.