Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covariance should be unknown when value is NaN #82

Open
rgov opened this issue Jun 29, 2023 · 0 comments
Open

Covariance should be unknown when value is NaN #82

rgov opened this issue Jun 29, 2023 · 0 comments

Comments

@rgov
Copy link

rgov commented Jun 29, 2023

When check_fix_by_variance is disabled, you can get NaN covariance values, but the position_covariance_type is still COVARIANCE_TYPE_DIAGONAL_KNOWN. Downstream receivers of this may not like that (https://github.com/foxglove/studio/issues/6337).

https://github.com/rgov/gps_umd/blob/b680df6142d7dfbc8a63224116b9a4a56e964c5b/gpsd_client/src/client.cpp#L297-L299

I've included this fix in my fork so it's also part of #57.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant