Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finder query comparisons gt, gte, lt, lte are reversed #130

Open
cognitiveflux opened this issue Jan 28, 2015 · 0 comments
Open

Finder query comparisons gt, gte, lt, lte are reversed #130

cognitiveflux opened this issue Jan 28, 2015 · 0 comments

Comments

@cognitiveflux
Copy link
Contributor

The greater or less than comparisons are reversed.

Example -- the gt() method as currently implemented:

def gt ...
... do |comparator, item|
comparator > item

which is receives yield query_string, comparator from do_comparison, substituting from above:

def gt ...
... do |query_string, comparator|
query_string > comparator

If you send SomeModel.where(:attribute).gt(1), that currently gets evaluated as:

def gt ...
... do |1, attribute_value|
1 > attribute_value

If you're looking for all model instances with the attribute value greater than 1, it should be:

def gt ...
... do |1, attribute_value|
1 < attribute_value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant