From 45187bc57a0471135ea2eecace5ff085f2d9fa3e Mon Sep 17 00:00:00 2001 From: Scott Field Date: Sun, 25 Aug 2024 09:47:37 -0400 Subject: [PATCH] Add note about how the subdomain boundaries are defined --- gwsurrogate/surrogate.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gwsurrogate/surrogate.py b/gwsurrogate/surrogate.py index 96bff20..5765610 100644 --- a/gwsurrogate/surrogate.py +++ b/gwsurrogate/surrogate.py @@ -2531,7 +2531,7 @@ class SEOBNRv4PHMSur(SurrogateEvaluator): IMPORTANT NOTES: -=============== +================ The original SEOBNRv4PHM model (arXiv:2004.09442) parameterizes the direction of the BH spins relative to the Newtonian orbital angular momentum @@ -2642,6 +2642,18 @@ def get_subdomain_ID(q, chiA0, chiB0): q : Mass ratio, mA/mB >= 1. chiA0: Dimensionless spin vector of the heavier black hole. chiB0: Dimensionless spin vector of the lighter black hole. + + IMPORTANT NOTES: + ================ + + Subdomains are defined based on the effective spin parameter + as computed in the early inspiral. While the effective spin + parameter is nearly constant throughout the inspiral it can change + by small amounts. Surrogates built in each subdomain are valid over + a larger region of the parameter space than the subdomain itself, + which helps in ensuring the model is accurate when evaluated + on a subdomain boundary and with spins specified at different + times/frequencies throughout the inspiral. """ chi1z = chiA0[2] chi2z = chiB0[2]