Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up from Pull request #2 (from Bitbucket code) #9

Open
sfield17 opened this issue Jun 28, 2020 · 0 comments
Open

Clean up from Pull request #2 (from Bitbucket code) #9

sfield17 opened this issue Jun 28, 2020 · 0 comments

Comments

@sfield17
Copy link
Contributor

Pull request #2 (bitbucket) was a bit of a rush job to get the code working. Three key pieces of cleanup work remain:

  1. param nudging might be best suited for TensorSplineGrid class which is what actually needs nudging. It will make independent calls to this class easier too

  2. consistent coding style.

  3. remove memoize decorator (see Jonathan's email "fast spline" for how to do this correctly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant