diff --git a/src/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Reflective.cpp b/src/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Reflective.cpp index 20e91730c2e35..c9cdfc546a6da 100644 --- a/src/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Reflective.cpp +++ b/src/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Reflective.cpp @@ -442,7 +442,7 @@ void Reflective::fd_ghost_impl( for (size_t i = 0; i < 3; ++i) { if (i == dim_direction) { get(outermost_prim_vars).get(i) = - -1.0 * get(get_boundary_val(interior_lorentz_factor)) * + -get(get_boundary_val(interior_lorentz_factor)) * get_boundary_val(interior_spatial_velocity).get(i); get(outermost_prim_vars).get(i) = -1.0 * get_boundary_val(interior_magnetic_field).get(i); @@ -464,7 +464,7 @@ void Reflective::fd_ghost_impl( get(outermost_prim_vars).get(i) = get(get_boundary_val(interior_lorentz_factor)) * min(normal_spatial_velocity_at_boundary, - normal_spatial_velocity_at_boundary * -1.0); + -normal_spatial_velocity_at_boundary); get(outermost_prim_vars).get(i) = min(get_boundary_val(interior_magnetic_field).get(i), -1.0 * get_boundary_val(interior_magnetic_field).get(i)); @@ -472,7 +472,7 @@ void Reflective::fd_ghost_impl( get(outermost_prim_vars).get(i) = get(get_boundary_val(interior_lorentz_factor)) * max(normal_spatial_velocity_at_boundary, - normal_spatial_velocity_at_boundary * -1.0); + -normal_spatial_velocity_at_boundary); get(outermost_prim_vars).get(i) = max(get_boundary_val(interior_magnetic_field).get(i), -1.0 * get_boundary_val(interior_magnetic_field).get(i)); diff --git a/tests/Unit/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Test_Reflective.cpp b/tests/Unit/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Test_Reflective.cpp index 3bd430d98ae2c..0e09020b177bd 100644 --- a/tests/Unit/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Test_Reflective.cpp +++ b/tests/Unit/Evolution/Systems/GrMhd/ValenciaDivClean/BoundaryConditions/Test_Reflective.cpp @@ -25,11 +25,11 @@ namespace helpers = ::TestHelpers::evolution::dg; namespace { -void test_stuffs(bool reflect_both) { +void test_stuffs(const bool reflect_both) { MAKE_GENERATOR(gen); const auto face_mesh_index = Index<2>{2}; - DataVector used_for_size{face_mesh_index.product()}; + const DataVector used_for_size{face_mesh_index.product()}; std::uniform_real_distribution<> dist(0.5, 1.0); const auto spatial_metric = @@ -43,7 +43,7 @@ void test_stuffs(bool reflect_both) { spatial_metric, sqrt_det_spatial_metric); // for factory string - std::string reflect_both_str = (reflect_both) ? "true" : "false"; + const std::string reflect_both_str = (reflect_both) ? "true" : "false"; helpers::test_boundary_condition_with_python< grmhd::ValenciaDivClean::BoundaryConditions::Reflective, @@ -108,5 +108,5 @@ SPECTRE_TEST_CASE("Unit.GrMhd.BoundaryConditions.Reflective", "[Unit][GrMhd]") { // Test for two cases of Reflective.reflect_both test_stuffs(true); - test_stuffs(true); + test_stuffs(false); }