Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape map incorrect inside excision #6451

Open
knelli2 opened this issue Jan 23, 2025 · 1 comment · May be fixed by #6477
Open

Shape map incorrect inside excision #6451

knelli2 opened this issue Jan 23, 2025 · 1 comment · May be fixed by #6477
Assignees
Labels

Comments

@knelli2
Copy link
Contributor

knelli2 commented Jan 23, 2025

The shape map needs to be valid inside the excision so that we can support the transition to ringdown code. A previous PR (#6359) extended the transition functions within the excisions, but this was not everything needed. There are a couple problems

  1. The shape map doesn't allow points at the center (
    ERROR(
    "The shape map does not support a (centered) point with radius zero. "
    "All centered coordinates: "
    ) This needs to be relaxed.
  2. The shape map incorrectly divides by the radius if the point is within the excison (
    transition_func_->operator()(centered_coords) *
    check_and_compute_one_over_radius(centered_coords));
    ). Instead, if the point is within the excision, the shape map should divide by the excision radius.
  3. The shape map has no knowledge of what the excision radius is, and therefore can't currently address 2. However the transition functions do. I believe the changes in Make shape map exactly like the one in SpEC #5636 related to having the shape map handle the division by radius were a mistake and that the transition function should be the one to handle the division of the radius.
  4. Once this is done, we can add the full grid to inertial map to the excision spheres.
@knelli2 knelli2 added the bug label Jan 23, 2025
@knelli2 knelli2 added this to the BBH Pipeline Automation milestone Jan 23, 2025
@knelli2 knelli2 self-assigned this Jan 23, 2025
@knelli2
Copy link
Contributor Author

knelli2 commented Jan 23, 2025

@AlexCarpenter46 Just FYI. I'll be fixing this soon.

@knelli2 knelli2 linked a pull request Feb 7, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant