-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color palettes #2035
Comments
What is its behavior under light and dark modes respectively? Specifically, can users use different color palettes for light and dark modes? If so, how can this be supported? If not, why? |
In the theme.toml light/dark could be supported by: [palette.light]
red = "#80AEFA"
green = "#CD9EFC"
white = "#FFA577"
[palette.dark]
... Or/in addition to that a palette could be used in |
I probably won't support it. Recently, I experimented with creating a color scheme-agnostic color palette based on yazi-rs/flavors, aiming to abstract common colors, but the results weren't great. Specifically, Yazi uses 16 abstract colors to cover the entire theme, but there are issues:
Because of this, introducing a color palette may not be truly meaningful compared to the effort and complexity it would add. So unless I see strong, convincing evidence that justifies it 1, this is unlikely to happen. Footnotes
|
I think you misunderstand. With the proposed color palettes theme feature, an arbitrary number of colors in the palette can be defined. There is no restriction to Yazi's 16 colors. I'd suggest looking again at the Starship palette configuration example I linked originally.
26 for each flavor actually :) |
Yazi's preset theme only uses ANSI colors (blue, red, etc.), if you define a custom color like
Indeed, not sure why I typed 36 :-/ |
Again, read how Starship's palette system works. We would do basically the exact same thing here. |
Specifically https://starship.rs/config/#example gives a good reference. Maybe something like this for Yazi: palette = "catppuccin_mocha"
[manager]
cwd = { fg = "${mauve}" }
[palettes.catppuccin_mocha]
rosewater = "#f5e0dc"
flamingo = "#f2cdcd"
pink = "#f5c2e7"
mauve = "#cba6f7"
red = "#f38ba8"
maroon = "#eba0ac"
peach = "#fab387"
yellow = "#f9e2af"
green = "#a6e3a1"
teal = "#94e2d5"
sky = "#89dceb"
sapphire = "#74c7ec"
blue = "#89b4fa"
lavender = "#b4befe"
text = "#cdd6f4"
subtext1 = "#bac2de"
subtext0 = "#a6adc8"
overlay2 = "#9399b2"
overlay1 = "#7f849c"
overlay0 = "#6c7086"
surface2 = "#585b70"
surface1 = "#45475a"
surface0 = "#313244"
base = "#1e1e2e"
mantle = "#181825"
crust = "#11111b" Someone could use this flavor, but then say - hmm, actually I want to use # theme.toml
flavor = "catppuccin_mocha"
[manager]
cwd = { fg = "${blue}" } Using the catppuccin_mocha flavor would inherit the Ideally the |
OK, I think I get what you mean now. You want to introduce a new color system parallel to the existing one, where the colors in the color palette don't directly correspond to the existing ANSI colors (red, blue, etc.), but instead function as an independent system, like Closing as not planned |
Would like to revisit #200, but I can't comment on it to get it reopened so I'll just copy it here.
The default themes don't use hex codes, but rather colors like "red" and "lightyellow". It would make it a lot easier for people to make their own simple color palette themes, keeping the choice of blue for this component or whatever, but allowing them to use their own shades of that color.
https://starship.rs/ has this kind of thing, e.g. https://github.com/catppuccin/starship/blob/e99ba6b210c0739af2a18094024ca0bdf4bb3225/starship.toml#L23-L133. They support arbitrary color names too, which should ideally be the case here as well.
The text was updated successfully, but these errors were encountered: