Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading all tags from no files #37

Closed
jangop opened this issue Feb 15, 2022 · 1 comment
Closed

Reading all tags from no files #37

jangop opened this issue Feb 15, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@jangop
Copy link

jangop commented Feb 15, 2022

The test

def test_read_all_from_no_file(self):
fails. This used to be (I think) because
def get_metadata(self, files, params=None):
returned None instead of [] but, looking at the source, apparently it (or rather get_tags) now raises TypeError if files evaluates to False (which both None and [] do).

Should that (raising TypeError) continue to be the expected behavior? If, so we should modify the test accordingly and adjust the docstring of get_metadata.

@sylikc
Copy link
Owner

sylikc commented Feb 15, 2022

I just fixed the test on this one with 715cfc8 . I changed it to a ValueError instead of a TypeError though... which seemed to make more sense...

@sylikc sylikc closed this as completed Feb 15, 2022
@sylikc sylikc added this to the PyExifTool v0.5 (Python3) milestone Feb 15, 2022
@sylikc sylikc added the bug Something isn't working label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants