Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert module JS and CSS to use silverstripe/webpack-config #232

Open
robbieaverill opened this issue Nov 30, 2017 · 2 comments
Open

Convert module JS and CSS to use silverstripe/webpack-config #232

robbieaverill opened this issue Nov 30, 2017 · 2 comments
Labels
affects/v4 complexity/medium impact/high type/api-break type/enhancement

Comments

@robbieaverill
Copy link
Contributor

Separating the JavaScript and CSS into SCSS modules will help for longer term maintainability, and will conform to the new suggested approach for building frontend assets in backend SS4 modules.

This was done in #225, which hasn't been merged yet. The commit a0ebe41 contains both the webpack separation as well as the new changes for that pull request, but could be separated out into its own pull request relatively easily.
@robbieaverill
Copy link
Contributor Author

Changed to major, because people may be referencing the old assets paths in their project code

@robbieaverill
Copy link
Contributor Author

The master branch is now 4.x-dev so we could break things in there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/high type/api-break type/enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robbieaverill