-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update field CSS #104
Update field CSS #104
Conversation
…e silverstripe grab icon in CMS context, modify cursor icon
I notice you haven't checked some of the boxes in the checklist. Can you please update your PR so that it complies with all of the guidelines? If you are unsure about any of the points I'm happy to help. |
@MrJamesEllis It's been a while since my last comment, are you still interested in getting this merged? |
This hasn't had any action since my last comment, so I'm going to close it. If you want to work on it going forward feel free to |
HI @GuySartorelli - for whatever reason Github hasn't notified me of updates here, or it did and they never made it to me. Regarding the unchecked task items, happy for you to provide some guidance on that as I don't think they apply in this case as it's just an enhancement to the visual layout of the field in the CMS. |
Hi, I will reopen after the relevant changes have been made. Regarding the checkboxes, they are all relevant except possibly the documentation one. Here's the rationale:
|
Can you also please provide a clear "before" and "after" screenshot for this change, since it's only a visual change? |
Description
This PR is for some visual enhancements and modernisation of the CSS for display the various multivalue fields, and aligns the fields with other fields in the administration area (e.g. taking up full width of container)
The update:
Manual testing steps
Apply the CSS, check for regressions. I haven't found any.
There may be some regressions where the field is used on the frontend, but developers should really be blocking/adding their own CSS there.
Issues
#105
Pull request checklist