Skip to content

Address.createFromRawAddress is not validating checksum #801

@fboucquez

Description

@fboucquez

When a user is creating an address, the constructor should be validating the checksum by default and not expect the user to call Address.isValidRawAddress before...

https://github.com/symbol/symbol-sdk-typescript-javascript/blob/main/src/model/account/Address.ts#L45

Note, I've added the validation and this breaks several invalid unit tests where the addresses are invalid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions