Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chart.js] Check if chart is already connected #1944

Open
wants to merge 6 commits into
base: 2.x
Choose a base branch
from
Open

[Chart.js] Check if chart is already connected #1944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eac34ba
Check if chart is already connected
Shadow-Devil Jun 28, 2024
e7e94a5
Move "chart is already connected" check
Shadow-Devil Jul 2, 2024
e1a1675
Also add check to src
Shadow-Devil Jul 2, 2024
a5c0204
Fix typescript error and build dist files
Shadow-Devil Jul 2, 2024
d84aeb0
Overwrite `initialize` instead of `connect` method since it is only c…
Shadow-Devil Jul 17, 2024
f5a5429
Destroy the chart on disconnect
Shadow-Devil Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Chartjs/assets/dist/controller.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export default class extends Controller {
};
private chart;
connect(): void;
disconnect(): void;
viewValueChanged(): void;
private dispatchEvent;
}
7 changes: 7 additions & 0 deletions src/Chartjs/assets/dist/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,13 @@ class default_1 extends Controller {
this.chart = new Chart(canvasContext, payload);
this.dispatchEvent('connect', { chart: this.chart });
}
disconnect() {
if (this.chart) {
this.chart.destroy();
this.chart = null;
}
this.dispatchEvent('disconnect', { chart: this.chart });
}
viewValueChanged() {
if (this.chart) {
const viewValue = { data: this.viewValue.data, options: this.viewValue.options };
Expand Down
9 changes: 9 additions & 0 deletions src/Chartjs/assets/src/controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,15 @@ export default class extends Controller {
this.dispatchEvent('connect', { chart: this.chart });
}

disconnect() {
if (this.chart) {
this.chart.destroy();
this.chart = null;
}

this.dispatchEvent('disconnect', { chart: this.chart });
}

/**
* If the underlying data or options change, let's update the chart!
*/
Expand Down