Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm not sure that you should check in xlsxwrap.d #33

Open
John-Colvin opened this issue Jul 3, 2019 · 9 comments
Open

I'm not sure that you should check in xlsxwrap.d #33

John-Colvin opened this issue Jul 3, 2019 · 9 comments

Comments

@John-Colvin
Copy link
Contributor

The definitions in it vary depending on system headers

@burner
Copy link
Contributor

burner commented Jul 3, 2019

Last time I checked dpp did not work on windows, so I put xlsxwrap in to make xlsxd work on windows.

@John-Colvin
Copy link
Contributor Author

This is true, it's not working great on windows.

On the other hand, xlsxd master current doesn't build on windows.

@burner
Copy link
Contributor

burner commented Jul 4, 2019

I will have a look

@John-Colvin
Copy link
Contributor Author

By "not working great" I mean "not working at all" by the way, it took a lot of work yesterday to get it over the threshold of the majority of the tests passing, so I wouldn't recommend even trying dpp on windows.

@burner
Copy link
Contributor

burner commented Jul 4, 2019

I was talking about taking a look at building xlsxd on windows. Not dpp

@John-Colvin
Copy link
Contributor Author

sure, just wanted to make sure you didn't get bogged down in dpp on windows in order to fix xlsxd

@burner
Copy link
Contributor

burner commented Jul 4, 2019

roger that

@John-Colvin
Copy link
Contributor Author

how that dpp on windows is looking better, we should revisit this.

@burner
Copy link
Contributor

burner commented Oct 22, 2019

is there any problem with the current version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants