Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Verification] Unsupported/missing verification #8608

Closed
squakez opened this issue Jun 1, 2020 · 3 comments · Fixed by #8678
Closed

[Verification] Unsupported/missing verification #8608

squakez opened this issue Jun 1, 2020 · 3 comments · Fixed by #8678
Assignees
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend

Comments

@squakez
Copy link
Contributor

squakez commented Jun 1, 2020

This is a...


[ ] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Documentation issue or request

Description

While working on #7466 I noticed that the UI is not treating a verification unsupported status properly, showing any unsupported verification as validated instead:

unsupported_verification

The verification endpoint returns:

[{"status":"UNSUPPORTED","scope":"PARAMETERS","errors":[{"code":"unknown-connector","description":"No connector for ID i-M8PdK9xYED-7ijVaUwYz registered"}]}]

But the UI is showing as verified correctly. I suggest to either show an error or a warning mentioning the verification is not supported for that connector.

@squakez squakez added cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend labels Jun 1, 2020
@gashcrumb
Copy link
Contributor

Yeah, looks like currently the UI is only concerned with an ERROR response. We could probably add a case for UNSUPPORTED but I don't know if I'd expose that error message as it is to the user.

@gashcrumb
Copy link
Contributor

I guess if a connector doesn't support validation we should hide/disable the "Validate" button instead.

@squakez
Copy link
Contributor Author

squakez commented Jun 2, 2020

I guess if a connector doesn't support validation we should hide/disable the "Validate" button instead.

I agree @gashcrumb. The problem I can see right now is how we can drive UI on that direction as the configuration to enable a validation process is not exposed through the API. I have opened another issue #8609 to take care of this particular situation, we may evaluate how to provide such configuration while working on it.

However I think we still have to provide a failsafe mechanism to cover any other response code that is not a real success validation. We probably won't have to give details to the user, just reporting that the validation process is not enabled for that connector.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/bug A bug which needs fixing group/ui User interface SPA, talking to the REST backend
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants