Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byteorder mark removal in UncSource removes first left angle bracket '<' of xml document #120

Open
sonntam opened this issue Feb 18, 2018 · 2 comments
Open

Byteorder mark removal in UncSource removes first left angle bracket '<' of xml document #120

sonntam opened this issue Feb 18, 2018 · 2 comments

Comments

@sonntam
Copy link

sonntam commented Feb 18, 2018 •
edited
Loading

For me loading of the update XML file fails because the byteorder mark removal in the UncSource.GetUpdatesFeed() method doesn't work as expected.

I found a solution at StackOverflow that fixes the issue.
The File.ReadAllText() method should recognize the UTF coding automatically anyway (see MSDN).

I implemented the fix in my fork. I suggest cherry-picking the commit sonntam/NAppUpdate@4522d37.
@synhershko
Copy link
Owner

Can you please submit a PR with a test checking several files in several formats?

@sonntam
Copy link
Author

sonntam commented Feb 27, 2018

I'm on it.

@sonntam sonntam mentioned this issue Feb 27, 2018
Merged
synhershko pushed a commit that referenced this issue Mar 24, 2018
@sonntam @synhershko
Issue #120: Byteorder mark removal in UncSource removes first left an…
e00b096 
…gle bracket '<' of xml document (#123)

* Fix removing bytorder mark not working
see https://stackoverflow.com/a/3282915/542269

* Added test cases for differently encoded XML files
Todo: Check XmlDeclaration for encoding and read file accordingly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@synhershko @sonntam