Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slack pipeline): read secrets from env or volumeMount #56

Open
5 tasks
kirederik opened this issue May 28, 2024 · 0 comments
Open
5 tasks

feat(slack pipeline): read secrets from env or volumeMount #56

kirederik opened this issue May 28, 2024 · 0 comments
Assignees
Labels

Comments

@kirederik
Copy link
Member

kirederik commented May 28, 2024

the current slack image uses kubectl to read a secret with a known name to find out the channel hook to send the notification to;

a better approach would to support reading the secret from env or from a file within the local system; this would allow penny to use env or volumeMounts on her pipeline spec. This would also making reading a secret with a known name redundant, so we can remove it.

tasks

  • support for getting the slack hook url from a environment variable
  • support for getting the slack hook url from a volumeMount
  • drop support from reading from a known secret
  • update docs
  • bump the version and release a new image
@kirederik kirederik self-assigned this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant