Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link replacement is broken in some situations #3

Open
synth opened this issue Jul 18, 2013 · 1 comment
Open

link replacement is broken in some situations #3

synth opened this issue Jul 18, 2013 · 1 comment
Assignees
Labels

Comments

@synth
Copy link
Owner

synth commented Jul 18, 2013

if you have "myapp.com/signup/verify?token=abc"
and then later a different link,say: "myapp.com"

replacement will occur poorly, doing the replacement of the first properly, but when we replace the second, it also replaces the first causing this malformed link:

myapp.com?source=abc/signup/verify?token=abc&source=abc

@ghost ghost assigned synth Jul 18, 2013
@synth
Copy link
Owner Author

synth commented Jul 18, 2013

yea, this is an issue when links appear that are a substring of other links, such as in root links. so this is pretty much a blocker for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant