* [ADD] Use internal QR code generator to avoid network related security risks

Author: nuxsmin

src/lib/Controllers/PreferencesController.php

@@ -127,7 +127,8 @@ protected function getSecurityTab()
 
                 $this->pluginContext->setUserData($authenticatorData);
 
-                $qrCode = $this->authenticatorService->getQrCode($userData->getLogin(), $authenticatorData->getIV());
+//                $qrCode = $this->authenticatorService->getQrCodeFromUrl($userData->getLogin(), $authenticatorData->getIV());
+                $qrCode = $this->authenticatorService->getQrCodeFromServer($userData->getLogin(), $authenticatorData->getIV());
             } elseif ($authenticatorData->isTwofaEnabled()
                 && $authenticatorData->getUserId() > 0
             ) {

src/lib/Services/AuthenticatorService.php

@@ -24,6 +24,8 @@
 
 namespace SP\Modules\Web\Plugins\Authenticator\Services;
 
+use BaconQrCode\Renderer\Image\Png;
+use BaconQrCode\Writer;
 use Base2n;
 use Defuse\Crypto\Exception\EnvironmentIsBrokenException;
 use GuzzleHttp\Client;
@@ -110,14 +112,14 @@ public static function checkUserToken(string $userToken, string $iv)
     }
 
     /**
-     * checkReleaseAction
+     * getQrCode
      *
      * @param string $login
      * @param string $iv
      *
      * @return bool
      */
-    public function getQrCode(string $login, string $iv)
+    public function getQrCodeFromUrl(string $login, string $iv)
     {
         try {
             $this->extensionChecker->checkCurlAvailable(true);
@@ -157,6 +159,24 @@ public function getUserQRUrl(string $login, string $iv)
         return $qrUrl;
     }
 
+    /**
+     * getQrCode
+     *
+     * @param string $login
+     * @param string $iv
+     *
+     * @return string
+     */
+    public function getQrCodeFromServer(string $login, string $iv)
+    {
+        $renderer = new Png();
+        $renderer->setHeight(200);
+        $renderer->setWidth(200);
+
+        $writer = new Writer($renderer);
+        return base64_encode($writer->writeString('otpauth://totp/sysPass:syspass/' . $login . '?secret=' . $iv . '&issuer=sysPass'));
+    }
+
     /**
      * Devolver un código de recuperación
      *