We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shouldn't the icon src be hashed in manifest.xjson?
manifest.xjson
https://github.com/sysgears/apollo-universal-starter-kit/blob/master/modules/favicon/common/assets/manifest.xjson#L5
It seems broken to me in the example heroku site https://apollo-universal-starter-kit.herokuapp.com/
This is what is expected.
To Reproduce Steps to reproduce the behavior:
Go to https://apollo-universal-starter-kit.herokuapp.com/
navigate to Manifest tab in chrome debugging tool https://developers.google.com/web/fundamentals/web-app-manifest/
see empty icon section.
The text was updated successfully, but these errors were encountered:
@zirho I think to fix this issue we should use val-loader: https://github.com/webpack-contrib/val-loader
val-loader
Sorry, something went wrong.
@larixer, How do you suggest doing it with val-loader?
Can we fix it by not hashing it for now, like it is done with favicon.ico?
No branches or pull requests
Shouldn't the icon src be hashed in
manifest.xjson
?https://github.com/sysgears/apollo-universal-starter-kit/blob/master/modules/favicon/common/assets/manifest.xjson#L5
It seems broken to me in the example heroku site
https://apollo-universal-starter-kit.herokuapp.com/
This is what is expected.
To Reproduce
Steps to reproduce the behavior:
Go to https://apollo-universal-starter-kit.herokuapp.com/
navigate to Manifest tab in chrome debugging tool
https://developers.google.com/web/fundamentals/web-app-manifest/
see empty icon section.
The text was updated successfully, but these errors were encountered: