Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a modal for "edit this page on Github" #80

Open
Firgrep opened this issue Sep 26, 2024 · 4 comments
Open

Create a modal for "edit this page on Github" #80

Firgrep opened this issue Sep 26, 2024 · 4 comments
Labels
feature request New feature or request

Comments

@Firgrep
Copy link
Member

Firgrep commented Sep 26, 2024

New users people to github might be overwhelmed by it, so we want to make sure that support is visible.

The "edit this page on Github" in the table of contents on the right panel should open a modal that gives the option to continue to github or go to the contributions page to learn about what Github is and how to use it.

We'll probably need to turn off the default link in Nextra from the theme config and build our custom component based off of their solution, except that it opens the modal instead of directly linking. Nextra exposes a useConfig hook, if I recall correctly, which should expose the dynamic github link.

@Firgrep Firgrep added the feature request New feature or request label Sep 26, 2024
@PatrickLarocque
Copy link

PatrickLarocque commented Sep 30, 2024

If you would like to assign me to this issue, my ongoing PR can be associated 😊

@Firgrep
Copy link
Member Author

Firgrep commented Nov 17, 2024

Pat's got busy, so if anyone else wants to pick this up! Just make a comment :)

@JMielbrecht
Copy link
Contributor

@Firgrep I'll take it! :)

@Firgrep
Copy link
Member Author

Firgrep commented Dec 2, 2024

@JMielbrecht MUI has a really nice Dialog component you could use for the modal functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
3 participants